Update the "Request Changes" and "Approve" buttons alignment#1350
Merged
RMacfarlane merged 1 commit intomicrosoft:masterfrom Oct 7, 2019
guilherme-gm:realign-description-buttons
Merged
Update the "Request Changes" and "Approve" buttons alignment#1350RMacfarlane merged 1 commit intomicrosoft:masterfrom guilherme-gm:realign-description-buttons
RMacfarlane merged 1 commit intomicrosoft:masterfrom
guilherme-gm:realign-description-buttons
Conversation
Contributor
|
Thanks @guilherme-gm! There's another place where buttons are put in a Can you make sure all the buttons get right aligned in this case? Code is here: |
…ht side, near the "Comment" button, in the Pull Request description page as they are related.
Contributor
Author
|
Oops, I didn't notce |
RMacfarlane
approved these changes
Oct 7, 2019
Contributor
RMacfarlane
left a comment
There was a problem hiding this comment.
Thanks, this looks great!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request updates the style of the PR Description page to move the
Request ChangesandApprovebuttons to the right side, near theCommentbutton. This way, those related functionalities are grouped together and far from theClose Pull Requestbutton.Related Issues: #297
Preview:
