Conversation
|
A visual distinction between drafts and open PRs like on the GitHub website would be nice, i.e. by making the |
|
@daviddossett In #4052 I informed you that your PR breaks icon button focus outline, but you didn't take my concern serious: #4052 (comment) After merging your changes from main into #4057 I noticed that my previously added support for focus is no longer visible. I hope that you take my concern seriously now and fix the issue that was caused by your PR. |
|
@Thomas1664 where are you still seeing the issue? It sounded like it was fixed by this PR removing the icons from the header. |
In the comment action bar. But you have to check out #4057 because the action buttons weren't visible before on focus. |
|
I already fixed it in #4066 |
I have a slight preference for leaving it as is. When you edit a comment in the overview, you get the text area. Keeping the title the same way is consistent. |
This PR addresses the following:
Title,Subtitle, andButtonGroupinto their own components.Before
After
Demo
CleanShot.2022-10-13.at.11.06.43.mp4
@alexr00 I didn't have the time but I think we should replace the title editing form with a quick pick like how Settings Profile rename works. Thoughts?
cc @digitarald