Update high contrast styles for buttons and inputs#3343
Merged
Conversation
daviddossett
commented
Feb 23, 2022
Contributor
Author
|
@alexr00 following up from the other issue—let me know if there were any questions here 🙏 |
alexr00
reviewed
Mar 31, 2022
webviews/common/common.css
Outdated
| .vscode-high-contrast input { | ||
| outline: none; | ||
| background: none !important; | ||
| background: var(--vscode-input.background); |
Member
There was a problem hiding this comment.
Should this be --vscode-input-background instead of --vscode-input.background?
Contributor
Author
There was a problem hiding this comment.
Good catch! Fixed.
Member
|
Looks like I forgot to submit my original review, which contained my question 🤦♀️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3342
Updates button and input rules of high contrast themes to include the correct background colors for buttons and inputs.
No visible difference to the original dark HC theme: