Skip to content

Updates TypeScript (released 4.2) and Octokit (to get fixed types), and a couple minor others#2525

Merged
alexr00 merged 1 commit intomainfrom
eamodio/update-deps
Dec 19, 2022
Merged

Updates TypeScript (released 4.2) and Octokit (to get fixed types), and a couple minor others#2525
alexr00 merged 1 commit intomainfrom
eamodio/update-deps

Conversation

@eamodio
Copy link
Contributor

@eamodio eamodio commented Feb 25, 2021

Also removes an as any because of the fixed octokit typings

@eamodio eamodio requested a review from RMacfarlane February 25, 2021 00:02
@eamodio eamodio self-assigned this Feb 25, 2021
package.json Outdated
"@types/temp": "0.8.34",
"@typescript-eslint/eslint-plugin": "4.15.1",
"@typescript-eslint/parser": "4.15.1",
"@typescript-eslint/eslint-plugin": "4.15.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we apply ^ everywhere?

RMacfarlane
RMacfarlane previously approved these changes Feb 25, 2021
Copy link
Contributor

@RMacfarlane RMacfarlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Removes any because of updated typings
@alexr00 alexr00 merged commit bc27729 into main Dec 19, 2022
@alexr00 alexr00 deleted the eamodio/update-deps branch December 19, 2022 16:30
@alexr00 alexr00 added this to the January 2023 milestone Dec 19, 2022
eslamashour1 pushed a commit to eslamashour1/vscode-pull-request-github that referenced this pull request Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants