Skip to content

add quote reply shortcut#1399

Merged
RMacfarlane merged 2 commits intomicrosoft:masterfrom
shaodahong:add-quote-reply
Oct 23, 2019
Merged

add quote reply shortcut#1399
RMacfarlane merged 2 commits intomicrosoft:masterfrom
shaodahong:add-quote-reply

Conversation

@shaodahong
Copy link
Contributor

@shaodahong shaodahong commented Oct 22, 2019

Closed #1396

1111

@RMacfarlane Hi, this my first pull request, and quote reply need a new icon, so what I to do?

@msftclas
Copy link

msftclas commented Oct 22, 2019

CLA assistant check
All CLA requirements met.

@shaodahong
Copy link
Contributor Author

now I use commentIcon, but I don't know this icon suitable for it

@rebornix rebornix self-assigned this Oct 22, 2019
Copy link
Contributor

@RMacfarlane RMacfarlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, nice work! I think commentIcon makes sense. Only one minor thing to fix and then this is good to merge

@shaodahong
Copy link
Contributor Author

shaodahong commented Oct 23, 2019

and have a question, I don't find .editorconfig or .prettierrc, so document changed when I format document, but I don't modify the document

@RMacfarlane
Copy link
Contributor

Yeah, there is no .editorconfig or .prettierrc for this project. There are also no linting rules for this formatting. Prettier and the built in VSCode JSON formatter both format arrays in the same way, so I think the change is OK. We had just never run format document on this before, and have the Format on Save setting turned off.

@RMacfarlane RMacfarlane merged commit 2fadc8c into microsoft:master Oct 23, 2019
@shaodahong shaodahong deleted the add-quote-reply branch October 24, 2019 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support quote reply

4 participants