Skip to content

Preserve expansaion state of tree view items on checkout#1392

Merged
RMacfarlane merged 1 commit intomasterfrom
jackson/preserve-expansion-state
Oct 17, 2019
Merged

Preserve expansaion state of tree view items on checkout#1392
RMacfarlane merged 1 commit intomasterfrom
jackson/preserve-expansion-state

Conversation

@JacksonKearl
Copy link
Contributor

Fixes #238 by adding an id parameter (the PR's URL) to the TreeItem's, whereas previously they defaulted to using the label as the id, which was not stable across checking out (the would come and go).

@JacksonKearl JacksonKearl force-pushed the jackson/preserve-expansion-state branch from b4c42d6 to 432cf9c Compare October 17, 2019 22:26
Copy link
Contributor

@RMacfarlane RMacfarlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@RMacfarlane RMacfarlane merged commit bbe9ef6 into master Oct 17, 2019
@RMacfarlane RMacfarlane deleted the jackson/preserve-expansion-state branch October 17, 2019 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PR node collapses after checking out PR in the overview page

2 participants