Align commit hash in PR description and avoid breaking username on hyphen#1357
Merged
RMacfarlane merged 2 commits intomicrosoft:masterfrom Oct 7, 2019
Merged
Conversation
RMacfarlane
approved these changes
Oct 7, 2019
Contributor
RMacfarlane
left a comment
There was a problem hiding this comment.
Thanks @JeffreyCA, this looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1353
This change makes sure the commit hash is always vertically centred. Previously it was aligned towards the top when the username overflows to two lines.
Before:
After:
Update:
Second commit prevents username from line-wrapping when there's a dash: