Review/Comment Suggestions are offset by one line if you make local changes first #6495
Description
- Extension version: v0.100.3 and v0.101.2024111911
- VSCode Version: 1.95.3
- OS: Windows
- Repository Clone Configuration: single repository
- Github Product Github.com
Steps to Reproduce:
See video:
Carnac_9EC2yeeg1G.mp4
- Create a simple repo
- (open vscode with temporary profile, so no conflicting extensions)
- (log in to github, all that jazz)
- Create a branch + PR for your simple repo (here's mine from the video: a change to put in a pr gabeseltzer/tv-mode#1)
- Refresh the PR viewer so that it sees the open PR
- Make a change to a line that was modified in the PR (or a line nearby)
- Save the file (optional, I did it in the video, but I have tested and it isn't necessary)
- Press the
+icon in the gutter to create a comment - Press "Make a Suggestion" (you can add additional comments, it doesn't matter)
- Confirm the suggestion with either "Start Review" or "Add Comment" (Also works if you already have a review open)
- Open Github and refresh the PR, and you'll see the suggestion is on the wrong line, it's one line down!
- (not in video) If you close and re-open VSCode, the comment will show in the line below the one you added it to, just like the Github website.