Skip to content

Suggestions end up in unsubmittable pending state #6494

@MetRonnie

Description

@MetRonnie
  • Extension version: v0.100.0
  • VSCode Version: 1.95.3 (system setup)
  • OS: Windows_NT x64 10.0.19045
  • Repository Clone Configuration: fork of an upstream repository
  • Github Product: Github.com

Steps to Reproduce:

  1. Make multiple changes to different "hunks" in a file and click the "Create pull request suggestions" button in the Source Control panel

    Here my suggestions ended up as 4 pending comments:

    gh-pr-bug-3-p1.mp4
  2. This can lead to multiple individual reviews being started on GitHub and only being able to submit a subset of the suggestions in the review

    On the GH website only 1 comment is in the review:

    gh-pr-bug-3-p2.mp4

    The other comments end up stuck as pending and cannot be submitted in a review

This is superficially similar to #4291, but in this case the comments clearly are making their way to the server in the pending state, but cannot be submitted.

#1317 may also be relevant

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions