-
Notifications
You must be signed in to change notification settings - Fork 720
Closed
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bugverifiedVerification succeededVerification succeeded
Milestone
Description
Version: 1.93.1 (system setup)
Commit: 38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40
Date: 2024-09-11T17:20:05.685Z
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Windows_NT x64 10.0.19045
Steps to Reproduce:
- Start a new Review
- Create a comment and click on Add Review Comment.
- Finish the Review
- Externally, resolve the comment
- Refresh the plugin
- open the comment
- Click on the Resolve Conversation button
- Actual Results:
- Check GitHub - notice that it wasn't resolved.
- The GUI didn't change.
- Expected Results:
- GitHub is notified about this resolution.
- The comment icon should change to something different - like:

- The "Resolve Conversation" button should either be disabled or changed to "Unresolve Conversation" and perhaps show a green check mark and/or a "Resolved" label at the top of the dialog box. Like so:
- Actual Results:

Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bugverifiedVerification succeededVerification succeeded