Skip to content

Refreshing a PR doesn't refresh comments #6252

@TristenFielding

Description

@TristenFielding

Version: 1.93.1 (system setup)
Commit: 38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40
Date: 2024-09-11T17:20:05.685Z
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Windows_NT x64 10.0.19045
Steps to Reproduce:

  1. Start a new Review
  2. Create a comment and click on Add Review Comment.
  3. Finish the Review
  4. Externally, resolve the comment
  5. Refresh the plugin
  6. open the comment
  7. Click on the Resolve Conversation button
    1. Actual Results:
      1. Check GitHub - notice that it wasn't resolved.
      2. The GUI didn't change.
    2. Expected Results:
      1. GitHub is notified about this resolution.
      2. The comment icon should change to something different - like: image
      3. The "Resolve Conversation" button should either be disabled or changed to "Unresolve Conversation" and perhaps show a green check mark and/or a "Resolved" label at the top of the dialog box. Like so:
image

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions