Skip to content

SCM title menu Create Pull Request action is unavailable when in a Remote window #3911

New issue
New issue
Closed
#5575
Closed
SCM title menu Create Pull Request action is unavailable when in a Remote window#3911
#5575
Assignees
lszomorualexr00
Labels
bugIssue identified by VS Code Team member as probable bugverifiedVerification succeeded
@joyceerhl

Description

@joyceerhl
joyceerhl
opened on Sep 1, 2022
  • Extension version: v0.51.2022090109
  • VSCode Version: 1.71-insider
  • OS: Windows 11

Steps to Reproduce:

  1. Open a GitHub codespace and go to the SCM view
  2. 🐛 the Create Pull Request button is not available. I have hit this in WSL and in a GitHub codespace so far so I suspect it is generic to all Remote-* windows in VS Code

From inspecting context keys, it looks like something is off with the scmProviderRootUri value in this when clause

vscode-pull-request-github/package.json

Lines 1601 to 1605 in 57dd877

{
"command": "pr.create",
"when": "scmProvider =~ /^git|^remoteHub:github/ && scmProviderRootUri in github:reposNotInReviewMode",
"group": "navigation"
}

Its value is a vscode-remote URI but the github.reposNotInReviewMode has file URIs.

image
image

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions