Skip to content

Web: Broken state for deleting branch in repo that deletes on merge #3453

@digitarald

Description

@digitarald
  • VSCode Version: github.dev

Steps to Reproduce:

  1. I reviewed a PR https://github.dev/microsoft/vscode/pull/146789
  2. Merged the PR and picked to delete the branch.

AR: Delete Branch is still shown, with a note that I can exit without deleting the branch. Is it deleted or not?
ER: When the branch is deleted, the UI sets to a welcome state where I can't commit or delete branches that don't exist.

image

A quick pick showed up a minute later to delete the branch, but clicking it just caused an error in the output:

[Info] PullRequestChangesTreeDataProvider> Error: Cannot resolve tree item for element 0/0:treeView.ts
[Info] GithubRepository> Unable to delete branch: HttpError: Reference does not exist

But even then the UI didn't change.


Refreshing still offers to exit without deleting the branch, but doesn't have a delete branch button anymore:

image

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions