Skip to content

Extension doesn't function with a GitLab submodule present #1330

@onnoowl

Description

@onnoowl

I've been trying to get this extension to work for GitHub Enterprise, but it seems to be getting stuck on the fact that my project has a submodule hosted by GitLab. In the output log, it appears to be trying to look for remotes there instead of at the GitHub Enterprise remote. I've checked with the main project's git remote -v, and everything looks fine:

origin	git@github.[redacted].git (fetch)
origin	git@github.[redacted].git (push)

Here's the log output.

[Debug 238387s 676ms] Looking for git repository
[Debug 238387s 677ms] Git repository found, initializing review manager and pr tree view.
[Debug 238387s 704ms] Review> Validate state in progress
[Debug 238387s 704ms] Review> Validating state...
[Debug 238388s 19ms] GitHubServer> Host https://gitlab.com/ntpsec/ntpsec is associated with GitHub: false
[Debug 238388s 19ms] No remote with name 'origin' found. Please update your 'githubPullRequests.remotes' setting.
[Debug 238388s 19ms] No remote with name 'upstream' found. Please update your 'githubPullRequests.remotes' setting.
[Debug 238388s 19ms] PullRequestManager> Displaying configured remotes: origin, upstream
[Debug 238388s 26ms] GitHubServer> Host https://gitlab.com/ntpsec/ntpsec is associated with GitHub: false
[Debug 238388s 26ms] No remote with name 'origin' found. Please update your 'githubPullRequests.remotes' setting.
[Debug 238388s 26ms] No remote with name 'upstream' found. Please update your 'githubPullRequests.remotes' setting.
[Debug 238388s 26ms] PullRequestManager> Displaying configured remotes: origin, upstream
[Debug 238388s 27ms] No GitHub remotes found
[Debug 238388s 27ms] Review> no matching pull request metadata found for current branch undefined
[Debug 238388s 28ms] No GitHub remotes found

Additionally, I'm not entirely sure I've authenticated correctly... Whenever I try to add this to my settings, it disappears:

"githubPullRequests.hosts": [ { "host": "https://github.[redacted]", "token": "[redacted]" } ]

I save the JSON file, but after reloading VS Code, it's gone.

Also, using the "Manually Provide Authentication Response" command doesn't give any errors, but I'm also not sure whether or not it's doing anything successfully.

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bug

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions