Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Conversation

@Ikuyadeu
Copy link
Contributor

Related #16.
I added copy summary and copy url when right click issue.

@chrmarti chrmarti added this to the September 2017 milestone Sep 26, 2017
@chrmarti
Copy link
Contributor

Hi @Ikuyadeu, thanks for your contribution!

I can see the Copy URL action being useful. I'm not sure about Copy Summary, because that usually consists of many lines of description and if someone wants to copy from it they are likely to first look at it (on github.com in the browser) and then decide on whether to copy it full or in part. What do you think?

@Ikuyadeu
Copy link
Contributor Author

Ikuyadeu commented Sep 29, 2017

@chrmarti Thank you for your review.
Copy Summary function is for user who doesn't want to switching code window to browser window.
I think some other solutions.

  1. Copy Summary to Copy Full Summary and Copy Summary Header, that can get summary's first line.
  2. Copy Summary to Preview Summary, that open Markdown preview

@chrmarti
Copy link
Contributor

I want to keep the functionality in the extension small and defer previewing of the summary to the website in the browser. I don't think opening the browser is a bad thing if it does not happen too often.

The current actions in the context menu provide shortcuts for things that do not require additional user interaction to be useful, that keeps the extension simple. Copy URL seems to fit that pattern, Copy Summary (or similar) needs something to preview/show the summary and does not seem to fit the pattern.

@Ikuyadeu
Copy link
Contributor Author

@chrmarti Thank you for your suggestion. I understand.
So I will remove only Copy Summary.

@chrmarti
Copy link
Contributor

@Ikuyadeu Great, happy to merge after that.

@Ikuyadeu
Copy link
Contributor Author

Ikuyadeu commented Oct 1, 2017

@chrmarti OK, I fixed!

@Ikuyadeu Ikuyadeu changed the title Add copy summary and url #16 Add copy url #16 Oct 1, 2017
@chrmarti chrmarti merged commit ff4c9d9 into microsoft:master Oct 2, 2017
@chrmarti
Copy link
Contributor

chrmarti commented Oct 2, 2017

Thanks @Ikuyadeu !

@Ikuyadeu Ikuyadeu deleted the extend_tooltip branch October 2, 2017 14:25
kieferrm pushed a commit to kieferrm/vscode-github-issues-prs that referenced this pull request Apr 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants