Python env file variable substitution: fix errors #4888
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the information about variable substitution in Python environment files was incorrect as written, as evidenced by the unit tests (see [here][test1] and [here][test2]). This commit replaces that information with language that describes the behavior of the code (see [here][code1] and [here][code2]) accurately. [test1]: https://github.com/microsoft/vscode-python/blob/94a6ba89c295145407388fdc0744e34314b2a325/src/test/common/variables/envVarsService.unit.test.ts#L409-L437 [test2]: https://github.com/microsoft/vscode-python/blob/94a6ba89c295145407388fdc0744e34314b2a325/src/test/common/variables/envVarsService.unit.test.ts#L500-L516 [code1]: https://github.com/microsoft/vscode-python/blob/94a6ba89c295145407388fdc0744e34314b2a325/src/client/common/variables/environment.ts#L121-L127 [code2]: https://github.com/microsoft/vscode-python/blob/94a6ba89c295145407388fdc0744e34314b2a325/src/client/common/variables/environment.ts#L135-L164
|
|
kini
added a commit
to kini/vscode-python
that referenced
this pull request
Oct 15, 2021
The behavior of interpreting "\n" inside quoted strings in env files was neither documented nor tested, so this commit modifies the unit tests to pin down that behavior. I also added a test for the example I'm proposing to add to the docs in PR microsoft/vscode-docs#4888. I also extended the test for escaping "$" to show that it works even when the "$" isn't part of something that matches SUBST_REGEX (i.e. isn't the beginning of something looking like "${...}").
kini
added a commit
to kini/vscode-python
that referenced
this pull request
Oct 15, 2021
The behavior of interpreting "\n" inside quoted strings in env files was neither documented nor tested, so this commit modifies the unit tests to pin down that behavior. I also added a test for the example I'm proposing to add to the docs in PR microsoft/vscode-docs#4888. I also extended the test for escaping "$" to show that it works even when the "$" isn't part of something that matches SUBST_REGEX (i.e. isn't the beginning of something looking like "${...}").
kini
added a commit
to kini/vscode-python
that referenced
this pull request
Oct 15, 2021
The behavior of interpreting "\n" inside quoted strings in env files was neither documented nor tested, so this commit modifies the unit tests to pin down that behavior. I also added a test for the example I'm proposing to add to the docs in PR microsoft/vscode-docs#4888. I also extended the test for escaping "$" to show that it works even when the "$" isn't part of something that matches SUBST_REGEX (i.e. isn't the beginning of something looking like "${...}").
Author
|
OK, actually something's odd here... the part about |
Contributor
|
Thanks for keeping us in the loop @kini! Please let us know if there are any more issues. |
karrtikr
pushed a commit
to microsoft/vscode-python
that referenced
this pull request
Jan 18, 2022
The behavior of interpreting "\n" inside quoted strings in env files was neither documented nor tested, so this commit modifies the unit tests to pin down that behavior. I also added a test for the example I'm proposing to add to the docs in PR microsoft/vscode-docs#4888. I also extended the test for escaping "$" to show that it works even when the "$" isn't part of something that matches SUBST_REGEX (i.e. isn't the beginning of something looking like "${...}").
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
…vscode-python#17747) The behavior of interpreting "\n" inside quoted strings in env files was neither documented nor tested, so this commit modifies the unit tests to pin down that behavior. I also added a test for the example I'm proposing to add to the docs in PR microsoft/vscode-docs#4888. I also extended the test for escaping "$" to show that it works even when the "$" isn't part of something that matches SUBST_REGEX (i.e. isn't the beginning of something looking like "${...}").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the information about variable substitution in Python
environment files was incorrect as written, as evidenced by the unit
tests (see here and here). This commit replaces
that information with language that describes the behavior of the
code (see here and here) accurately.