New Accessibility Service depending on new native node module #68973
Conversation
bpasero
left a comment
There was a problem hiding this comment.
As discussed, I suggest to rather introduce a IAccessibilityService and not use "throw Error" for conditional programming. I would also throw in the functionality of getAccessibilitySupport and onDidChangeAccessibilitySupport
bpasero
left a comment
There was a problem hiding this comment.
@sbatten I like this. I will add @alexandrudima as reviewer given the changes for the standalone editor.
| "vscode-ripgrep": "^1.2.5", | ||
| "vscode-sqlite3": "4.0.7", | ||
| "vscode-textmate": "^4.0.1", | ||
| "vscode-windows-registry": "^1.0.0", |
There was a problem hiding this comment.
@sbatten should this move into optionalDependencies?
|
Maybe one thing to test is the performance impact of accessing the windows registry on startup. @alexandrudima are we already doing this on Windows for keybindings? Do we have an idea about the timing? |
|
@sbatten would be great if you could also try to use registerSingleton and move the service out of workbench + have it as lazy service (see bulk edit service as example). |
|
@bpasero Yeah, we are going into |
…oft#68973) * new reg service and always on mnemonics * missed one * use new node module and accessibility service * add typings * adopt accessibility service * make it lazy
replaces #65529
fixes #54349