Fixes #46027 by using box-shadow css to render guides#46029
Merged
alexdima merged 2 commits intomicrosoft:masterfrom Mar 26, 2018
Merged
Fixes #46027 by using box-shadow css to render guides#46029alexdima merged 2 commits intomicrosoft:masterfrom
alexdima merged 2 commits intomicrosoft:masterfrom
Conversation
…r than background color and computed width ...should also be faster without these computations
|
|
Member
|
This is very cool! Thank you! I will just push a follow-up commit to remove the usage of CSS variables, as this is not supported in IE11 (supported by the monaco editor) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rather than background color and computed width
Should also be faster without these computations