Reinstate colors of symbol codicons when used in custom tree views#320391
Reinstate colors of symbol codicons when used in custom tree views#320391gjsjohnmurray wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates tree view icon rendering so theme icons without an explicit color get a fallback CSS class applied.
Changes:
- Add
codicon-coloredclass whennode.themeIconhas nocolorconfigured.
| templateData.icon.style.color = this.themeService.getColorTheme().getColor(node.themeIcon.color.id)?.toString() ?? ''; | ||
| } else { | ||
| iconClass = iconClass + ' codicon-colored'; | ||
| } |
There was a problem hiding this comment.
This issue appears to predate this PR
|
Validated using the extension-samples branch documented at #299479 (comment)
|
|
@gjsjohnmurray can #311339 be affected by this? (SVG |
|
@gjsjohnmurray did some testing of this PR, maybe I'm doing something wrong, but can't confirm colors fallback to defaults:
Icons assigned as Can be related to the issue - even some |
|
@n-gist is the source of your test extension available somewhere? I'm puzzled that symbol-* codicons aren't colored in the quickpick. |
|
@gjsjohnmurray it is not released yet, but I can share current version. Do you need source code or vsix would be enough? Send it somewhere? |
|
@gjsjohnmurray sent an invite to https://github.com/n-gist/temp.vscode.focus To test icons - open a project and drop some files/folders to the extension view, and their icons will be customizeable.
Open issue in repo for any needs, I would be happy to assist with testing/fixing icons issues. |


This PR fixes #299479
Issue was caused by #267787