Prevent symbol-* codicons from displaying colored on toolbars (fix #267766)#267787
Prevent symbol-* codicons from displaying colored on toolbars (fix #267766)#267787jrieken merged 18 commits intomicrosoft:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where symbol icons (codicon-symbol-*) were displaying with colors in toolbars when they should remain uncolored. The fix prevents these symbol icons from applying their themed colors when they appear within toolbar contexts.
- Adds
:not(.monaco-toolbar .codicon.codicon-symbol-*)exclusions to all symbol icon color rules - Ensures symbol icons in toolbars maintain default appearance without themed coloring
- Preserves existing colored symbol icon behavior in non-toolbar contexts
|
To verify, use the repro steps at #267766 (comment) and confirm that the button is no longer colored. |
|
Please consider taking this simple bugfix PR in time for next week's endgame. |
|
Please approve and merge this. |
jrieken
left a comment
There was a problem hiding this comment.
If we do it, we should have better CSS rules here, but lets see how the discussion about the "if" goes
jrieken
left a comment
There was a problem hiding this comment.
(pressed Approve when I wanted changes)
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
This PR fixes #267766