fix(accessibility): Add ARIA hints and fix spurious announcements in find widgets#292376
Merged
meganrogge merged 3 commits intomicrosoft:mainfrom Feb 5, 2026
Merged
Conversation
This PR improves UX polish with ARIA hint improvements and critical bug fixes for find widget screen reader behavior. ARIA Hint Improvements: Added aria-description to announce 'Press Alt+F1 for accessibility help' - simpleFindWidget.ts: Base widget for Terminal/Webview/Browser find - searchWidget.ts: Search across files widget - terminalFindWidget.ts: Terminal find widget - webviewFindWidget.ts: Webview find widget - viewFilter.ts: Tree view filters (Problems, Output, etc.) Bug Fixes in findWidget.ts: 1. Only announce search results when search string is present - Prevents spurious 'No results' announcements on empty search 2. Check widget visibility before updating aria-label - Prevents stale announcements when dialog is hidden Double-speak Prevention Pattern: - Track hint announcement with flag - Include hint in ARIA label on first reveal - Reset to plain label after 1 second timeout - Reset flag on widget hide/close This is PR 3 of 3 for the Accessibility Help System. Depends on: PR 2 (Accessibility Help Content)
Contributor
Author
|
@meganrogge Here is the other pr, which is mainly fixes. |
…out for proper lifecycle management, and removed unused resetAccessibilityHelpHint methods.
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
dmitrivMS
approved these changes
Feb 5, 2026
daviddossett
pushed a commit
to daviddossett/vscode
that referenced
this pull request
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds ARIA hints and fixes spurious screen reader announcements in find/filter widgets to improve the accessibility experience.
Fixes #292375
Changes
Bug Fixes
Guard search result announcements in
findWidget.ts:Check widget visibility before updating aria-label:
ARIA Hint Additions
Added accessibility help hints to find widgets that inherit from
SimpleFindWidget:_accessibilityHelpHintAnnouncedflagaccessibility.verbosity.findsetting is enabledFiles Changed
src/vs/editor/contrib/find/browser/findWidget.tssrc/vs/workbench/contrib/codeEditor/browser/find/simpleFindWidget.tssrc/vs/workbench/browser/parts/views/viewFilter.tssrc/vs/workbench/contrib/search/browser/searchWidget.tssrc/vs/workbench/contrib/terminalContrib/find/browser/terminalFindWidget.tssrc/vs/workbench/contrib/webview/browser/webviewFindWidget.tsTesting
Related