fix: memory leak in ipc #282253
Merged
fix: memory leak in ipc #282253
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
dmitrivMS
approved these changes
Dec 15, 2025
przpl
pushed a commit
to przpl/vscode
that referenced
this pull request
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak in ipc, generated by GitHub Copilot.
Before
When opening and closing an image editor 97 times, the number of
ChannelClient.requestEventfunctions seems to grow by 1 each time:{ "namedFunctionCount3": [ { "count": 297, "delta": 291, "name": "anonymous", "sourceLocation": "resources/app/out/vs/workbench/workbench.desktop.main.js:565:47809", "originalLocation": "src/vs/workbench/api/browser/mainThreadStatusBar.ts:74:32", "originalName": "MainThreadStatusBar.$setEntry" }, { "count": 156, "delta": 97, "name": "onWillAddFirstListener", "sourceLocation": "resources/app/out/vs/workbench/workbench.desktop.main.js:560:514", "originalLocation": "src/vs/base/parts/ipc/common/ipc.ts:662:27", "originalName": "doRequest" }, { "count": 156, "delta": 97, "name": "onDidRemoveLastListener", "sourceLocation": "resources/app/out/vs/workbench/workbench.desktop.main.js:560:648", "originalLocation": "src/vs/base/parts/ipc/common/ipc.ts:677:28", "originalName": "ChannelClient.requestEvent" }, { "count": 156, "delta": 97, "name": "l", "sourceLocation": "resources/app/out/vs/workbench/workbench.desktop.main.js:560:723", "originalLocation": "src/vs/base/parts/ipc/common/ipc.ts:688:29", "originalName": "ChannelClient.requestEvent" } ], "isLeak": true }After
When opening and closing an image editor 97 times, the number of
ChannelClient.requestEventstays constant: