fix: memory leak in local process extension host #279351
Merged
+19
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak in local process extension host by setting the port message listener to null on dispose
Also changes
this._toDispose.addto usingthis._registerwhich overall seems a bit simpler.Before & After Comparison
Barely noticable, but one can see at the bottom there is one less leak.
The chart shows restarting extensions 97 times, before and after.