Git - use diff instead of diff-tree for showing commit data and comparing branches#273969
Merged
Git - use diff instead of diff-tree for showing commit data and comparing branches#273969
Conversation
…omparing branches
DonJayamanne
previously approved these changes
Oct 29, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Git extension's diff operations by consolidating diffTrees into diffBetween and standardizing the parameter patterns across diff methods. The refactoring introduces an options object pattern to diffBetween for better extensibility and removes the now-redundant diffTrees and diffBetweenShortStat methods.
Key changes:
- Replaced
diffTreeswithdiffBetweenacross all call sites - Converted
diffBetweeningit.tsto use an options object withpath,similarityThreshold, andsymmetricparameters - Refactored
diffFilesto accept an options object instead of positional boolean parameters - Updated all internal diff method calls to use the new options-based signature
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| extensions/git/src/git.ts | Refactored diffBetween to use options object, removed diffTrees and diffBetweenShortStat, updated diffFiles signature to use options |
| extensions/git/src/repository.ts | Updated diffBetween wrapper to pass options object with similarityThreshold configuration to underlying implementation, removed diffTrees and diffBetweenShortStat wrappers |
| extensions/git/src/historyProvider.ts | Changed diffTrees call to diffBetween |
| extensions/git/src/commands.ts | Changed all diffTrees calls to diffBetween |
DonJayamanne
approved these changes
Oct 29, 2025
dmitrivMS
pushed a commit
that referenced
this pull request
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.