Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a timing issue in the language model cache management by moving the _clearModelCache() call to occur after model metadata is mapped, but before the new models are stored in the cache.
Key changes:
- Moves
_clearModelCache(vendor)from line 176 (before provider call and mapping) to line 217 (after mapping, before cache population) - Removes an unnecessary blank line in the for loop
Tyriar
approved these changes
Oct 29, 2025
lszomoru
approved these changes
Oct 29, 2025
dmitrivMS
pushed a commit
that referenced
this pull request
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix https://github.com/microsoft/vscode-copilot-evaluation/issues/659