Rename ChatService.getHistory to getLocalSessionHistory#273841
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Oct 29, 2025
Merged
Rename ChatService.getHistory to getLocalSessionHistory#273841mjbvz merged 1 commit intomicrosoft:mainfrom
ChatService.getHistory to getLocalSessionHistory#273841mjbvz merged 1 commit intomicrosoft:mainfrom
Conversation
Trying to make it more clear that this only returns the local sessions, not those from providers
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames the getHistory() method to getLocalSessionHistory() across the chat service interface, implementation, and all its usages. The new name better reflects that this method specifically retrieves local session history rather than all history types.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/chatService.ts | Updates the interface method signature from getHistory() to getLocalSessionHistory() |
| src/vs/workbench/contrib/chat/common/chatServiceImpl.ts | Updates the implementation method name to match the interface change |
| src/vs/workbench/contrib/chat/test/common/mockChatService.ts | Updates the mock service to match the renamed interface method |
| src/vs/workbench/contrib/chat/browser/chatWidget.ts | Updates method call to use the new name |
| src/vs/workbench/contrib/chat/browser/chatSessions/view/sessionsTreeRenderer.ts | Updates method call to use the new name |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionViewModel.ts | Updates method call to use the new name |
| src/vs/workbench/contrib/chat/browser/actions/chatActions.ts | Updates two method calls to use the new name |
bpasero
approved these changes
Oct 29, 2025
dmitrivMS
pushed a commit
that referenced
this pull request
Oct 29, 2025
Rename `ChatService.getHistory` to `getLocalSessionHistory`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to make it more clear that this only returns the local sessions, not those from providers
@roblourens Please let me know if this isn't correct