Revert "feat: reenable asar support"#272935
Merged
joaomoreno merged 1 commit intomainfrom Oct 23, 2025
Merged
Conversation
This reverts commit ff89137.
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
@TylerLeonhardtMatched files:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the ASAR (Electron Archive) support that was previously enabled in PR #272552. The changes disable ASAR packaging functionality across the codebase by introducing a canASAR flag set to false and removing ASAR-specific implementation code.
Key Changes:
- Introduces
canASAR = falseflag to disable ASAR support throughout the codebase - Removes ASAR-specific module resolution hooks from bootstrap code
- Simplifies node_modules path handling by reverting to non-ASAR paths
- Updates build scripts to work with standard node_modules structure instead of ASAR archives
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/amdX.ts | Added canASAR flag and updated module loading logic to check it |
| src/vs/base/common/platform.ts | Removed hasElectronUserAgent export |
| src/vs/base/common/network.ts | Reverted ASAR path constants to simpler structure |
| src/vs/workbench/services/treeSitter/browser/treeSitterLibraryService.ts | Updated to check canASAR flag for path resolution |
| src/vs/workbench/services/textMate/browser/textMateTokenizationFeatureImpl.ts | Updated to check canASAR flag for WASM file loading |
| src/vs/workbench/services/textMate/browser/backgroundTokenization/threadedBackgroundTokenizerFactory.ts | Updated to check canASAR flag for module location |
| src/vs/workbench/services/languageDetection/browser/languageDetectionWorkerServiceImpl.ts | Updated to check canASAR flag for worker initialization |
| src/bootstrap-node.ts | Removed ASAR support helper function |
| src/bootstrap-esm.ts | Removed ASAR-specific module resolution hooks, simplified to only map 'fs' to 'original-fs' |
| build/linux/dependencies-generator.ts | Added canAsar flag to conditionally use ASAR paths |
| build/linux/dependencies-generator.js | Compiled JavaScript version of dependencies-generator changes |
| build/lib/asar.ts | Restructured file duplication logic for non-ASAR packaging |
| build/lib/asar.js | Compiled JavaScript version of asar.ts changes |
| build/gulpfile.vscode.js | Updated ASAR creation to use node_modules subdirectory and adjusted vsda handling comments |
deepak1556
approved these changes
Oct 23, 2025
deepak1556
added a commit
that referenced
this pull request
Oct 23, 2025
This reverts commit 5e4cf38.
deepak1556
added a commit
that referenced
this pull request
Oct 30, 2025
This reverts commit 5e4cf38.
deepak1556
added a commit
that referenced
this pull request
Nov 3, 2025
This reverts commit 5e4cf38.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #272552