Work towards getting isolated built-in extension compiles#271171
Merged
mjbvz merged 6 commits intomicrosoft:mainfrom Oct 13, 2025
Merged
Work towards getting isolated built-in extension compiles#271171mjbvz merged 6 commits intomicrosoft:mainfrom
mjbvz merged 6 commits intomicrosoft:mainfrom
Conversation
For microsoft#271167 This makes it so our built-in extensions can mostly be built using `tsc` on the command line. Previously the extensions were picking up a lot of typing info from the root `node_modules` that meant they weren't truly independent
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds typeRoots configurations to built-in extension TypeScript configurations to enable isolated compilation with tsc on the command line. The primary goal is to make extensions independent of typing information from the root node_modules directory.
- Added
typeRoots: ["./node_modules/@types"]to extension tsconfig.json files - Updated several
@types/mochadependencies from version 9.x to 10.x - Added
skipLibCheck: truefor extensions with problematic published@typespackages
Reviewed Changes
Copilot reviewed 52 out of 59 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| extensions/*/tsconfig.json | Added typeRoots configuration pointing to local node_modules/@types |
| extensions/*/package.json | Updated @types/mocha to version 10.x and added missing @types/node dependencies |
| extensions/terminal-suggest/tsconfig.json | Duplicate typeRoots entries added |
| extensions/notebook-renderers/src/htmlHelper.ts | Added type annotations and cast for trustedTypes |
Files not reviewed (7)
- extensions/ipynb/package-lock.json: Language not supported
- extensions/markdown-language-features/package-lock.json: Language not supported
- extensions/mermaid-chat-features/package-lock.json: Language not supported
- extensions/notebook-renderers/package-lock.json: Language not supported
- extensions/search-result/package-lock.json: Language not supported
- extensions/terminal-suggest/package-lock.json: Language not supported
- extensions/vscode-api-tests/package-lock.json: Language not supported
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @TylerLeonhardtMatched files:
|
roblourens
previously approved these changes
Oct 13, 2025
dmitrivMS
previously approved these changes
Oct 13, 2025
dmitrivMS
approved these changes
Oct 13, 2025
auto-merge was automatically disabled
October 13, 2025 22:37
Pull request was closed
pwang347
pushed a commit
that referenced
this pull request
Oct 14, 2025
Work towards getting isolated built-in extension compiles
pwang347
pushed a commit
that referenced
this pull request
Oct 14, 2025
Work towards getting isolated built-in extension compiles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #271167
This makes it so our built-in extensions can mostly be built using
tscon the command line:cd extensions/markdown-language-features npx tsc -p tsconfig.json -noEmitPreviously the extensions were picking up a lot of typing info from the root
node_moduleswhich meant they weren't truly independentI had to add a few skipLibChecks for tricky issues with published
@types. Will revisit these later