fix: properly update cloned stylesheets on mutation in firefox#269126
fix: properly update cloned stylesheets on mutation in firefox#269126bpasero merged 1 commit intomicrosoft:mainfrom
Conversation
|
@CGNonofr very nice (have to confirm it works), can we make this change with |
I have the feeling that characterData is the mutation we are looking for, and that childList is the one webkit-specific 🤔 What do you think? |
|
@CGNonofr I actually tested this with a full insiders build and it turns out I only get it to work with both of them. Can you change it to this: subtree: isFirefox, characterData: isFirefoxAnd update the PR? |
3405e0e to
3cae081
Compare
I'm not sure why you consider having characterData and subtree enabled outside of firefox harmful, I would even say that it's probably more futur-proof 🤷 but I've amended the commit |
That is fair, but I feel uneasy doing a change without fully understanding what it fixes for the other browsers. It seems that all other browsers are doing fine so far, ever since we shipped floating windows. |
fix #259835
It looks like the solution was quite simple at the end @bpasero
Tested with firefox 143