Skip to content

Engineering - try to run mangling in the PR check#268428

Merged
lszomoru merged 9 commits intomainfrom
lszomoru/pr-mangling
Oct 29, 2025
Merged

Engineering - try to run mangling in the PR check#268428
lszomoru merged 9 commits intomainfrom
lszomoru/pr-mangling

Conversation

@lszomoru
Copy link
Member

No description provided.

@lszomoru lszomoru self-assigned this Sep 26, 2025
@lszomoru lszomoru added this to the September 2025 milestone Sep 26, 2025
@lszomoru lszomoru added the engineering VS Code - Build / issue tracking / etc. label Sep 26, 2025
@lszomoru lszomoru marked this pull request as ready for review September 26, 2025 11:13
Copilot AI review requested due to automatic review settings September 26, 2025 11:13
@lszomoru lszomoru enabled auto-merge (squash) September 26, 2025 11:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR attempts to run mangling in the PR check by modifying the compilation step in the GitHub Actions workflow to use the full build targets instead of the PR-specific ones.

Key Changes

  • Switches from core-ci-pr and extensions-ci-pr to core-ci and extensions-ci in the PR workflow

@lszomoru lszomoru marked this pull request as draft September 26, 2025 12:18
auto-merge was automatically disabled September 26, 2025 12:18

Pull request was converted to draft

@lszomoru lszomoru modified the milestones: September 2025, October 2025 Sep 30, 2025
@lszomoru
Copy link
Member Author

Closing this PR for now as there is no consensus that this should be enabled.

@lszomoru lszomoru closed this Sep 30, 2025
@lszomoru lszomoru reopened this Oct 29, 2025
@lszomoru lszomoru marked this pull request as ready for review October 29, 2025 08:46
@lszomoru lszomoru enabled auto-merge (squash) October 29, 2025 08:46
@lszomoru lszomoru merged commit 0aead43 into main Oct 29, 2025
29 checks passed
@lszomoru lszomoru deleted the lszomoru/pr-mangling branch October 29, 2025 09:04
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Dec 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

engineering VS Code - Build / issue tracking / etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants