-
Notifications
You must be signed in to change notification settings - Fork 37.4k
fix copy with multiple cursors and empty selections #256083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@alexdima I think your unit tests in |
|
@microsoft-github-policy-service agree |
|
Should I be the one to merge it (I would guess not) |
I don't see the button anywhere, so I'll leave it to you. |
When having
emptySelectionClipboard: true,and when you have multiple cursors and all of them are empty,
and when we copy,
each cursor should copy its own line.
Fixes: #256039
There is a room for improvement: mainly, when pasting, VSCode pastes at the cursor position, not in the line above (like it does with just one cursor and copying of the empty selection).
(reference 1 (for later))
Testing:
emptySelectionClipboard: truein settingsCurrently, it copies
"a\nb\n"in both places:It should produce
But because aforementioned issue (reference 1), it produces
Which is good enough (and better than what we currently have).
Though, this can be easily avoided by, before Pasting, setting cursors at the beginning of the lines:
And then Paste correctly produces