Add SecretStorage.keys() as proposed API#252804
Add SecretStorage.keys() as proposed API#252804TylerLeonhardt merged 5 commits intomicrosoft:mainfrom
SecretStorage.keys() as proposed API#252804Conversation
|
/assign @TylerLeonhardt |
Useful for testing PR microsoft/vscode#252804
|
https://github.com/gjsjohnmurray/vscode-extension-samples/tree/test-vscode-252804 provides a way of testing this by adding the following commands to authenticationprovider-sample:
Run the first one or more times, then run the second to see the keys, then the third to delete them all. |
|
Any chance of getting this into this week's endgame? |
|
Im on vacation til the 17th so it won't make this endgame |
| get(key: string): Promise<string | undefined>; | ||
| set(key: string, value: string): Promise<void>; | ||
| delete(key: string): Promise<void>; | ||
| keys(): Promise<string[]>; |
There was a problem hiding this comment.
This has to be optional to start... because vscode.dev, github.dev, and maybe code serve-web & @vscode/test-web implement one of these providers and bring them in via:
vscode/src/vs/workbench/browser/web.api.ts
Line 237 in 73fbb0c
since they don't have an implementation today, we should assume that this keys is optional... and error accordingly.
There was a problem hiding this comment.
I can probably easily implement this for vscode.dev... but github.dev I don't have control over... so no promises.
There was a problem hiding this comment.
edit: we don't need to worry about serve-web because of:
There was a problem hiding this comment.
edit: I don't think we need to worry about @vscode/test-web:
https://github.com/microsoft/vscode-test-web/blob/main/src/browser/main.ts#L266-L269
There was a problem hiding this comment.
I have pushed an update. I hope I understood you correctly.
There was a problem hiding this comment.
I've made the change for vscode.dev so that should work (in insiders.vscode.dev)
This PR implements #196616 by adding
SecretStorage.keys()behind asecretStorageKeysproposed API gate.