#188711 - Walkthrough Focus-Visible Outline #247650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhavyaus
approved these changes
Apr 29, 2025
connor4312
approved these changes
Apr 29, 2025
NikolaRHristov
pushed a commit
to CodeEditorLand/Editor
that referenced
this pull request
Apr 30, 2025
188711 focus outline visibility
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #188711
The focus-visible outline on Walkthrough buttons was being cut off due to the absolute positioning of the progress bar. This PR resolves the issue, ensuring that buttons without progress bars remain unaffected.
Each screenshot is of the keyboard focus on a default theme provided by VS Code:
Default Light Modern:
Default Dark Modern:
Default High Contrast:
Note: A margin already exists that attempts to provide room for the focus-visible border of all buttons under the
gettingStartedContainerdiv here. However, this CSS does not take precedence over other selectors using thegetting-started-categoryclass. Not sure if there is a cleanup opportunity there, but wanted to call it out since it influenced my changes.