Skip to content

fix: handle cancellation errors inside edit session identity provider #247450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joyceerhl merged 1 commit into from
Apr 28, 2025
Merged

fix: handle cancellation errors inside edit session identity provider #247450

joyceerhl merged 1 commit into from
Apr 28, 2025

Conversation

@alexweininger
Copy link
Member

@alexweininger alexweininger commented Apr 25, 2025 •
edited
Loading

Fix #247449

Fix ensures that a cancellation error thrown from this._onWillCreateEditSessionIdentity are bubbled up.

@bamurtaugh bamurtaugh requested a review from joyceerhl April 25, 2025 21:54
joyceerhl
joyceerhl approved these changes Apr 27, 2025
View reviewed changes
Copy link
Contributor

@joyceerhl joyceerhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vs-code-engineering vs-code-engineering bot added this to the April 2025 milestone Apr 27, 2025
@joyceerhl joyceerhl merged commit 0237863 into microsoft:main Apr 28, 2025
7 checks passed
NikolaRHristov pushed a commit to CodeEditorLand/Editor that referenced this pull request Apr 30, 2025
@alexweininger
fix: handle cancellation errors inside edit session identity provider (…
3fb9a99 
…microsoft#247450)
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jun 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

+1 more reviewer

@joyceerhl joyceerhl joyceerhl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@joyceerhl joyceerhl

Labels

None yet

Projects

None yet

Milestone

April 2025

Development

Successfully merging this pull request may close these issues.

Unable to cancel out of publish modal in Continue On feature

4 participants

@alexweininger @DonJayamanne @joyceerhl @TylerLeonhardt