Skip to content

Revert "Engineering - background codesign for Windows stage (#245796)" #245869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lszomoru merged 1 commit into from
Apr 7, 2025
Merged

Revert "Engineering - background codesign for Windows stage (#245796)" #245869

lszomoru merged 1 commit into from
Apr 7, 2025

Conversation

@lszomoru
Copy link
Member

@lszomoru lszomoru commented Apr 7, 2025

This reverts commit e1ff10f.

@lszomoru lszomoru self-assigned this Apr 7, 2025
@lszomoru lszomoru enabled auto-merge (squash) April 7, 2025 10:37
@lszomoru lszomoru added the engineering VS Code - Build / issue tracking / etc. label Apr 7, 2025
@lszomoru lszomoru added this to the April 2025 milestone Apr 7, 2025
@lszomoru lszomoru disabled auto-merge April 7, 2025 10:41
@lszomoru lszomoru marked this pull request as draft April 7, 2025 10:41
@lszomoru lszomoru marked this pull request as ready for review April 7, 2025 10:44
@lszomoru lszomoru enabled auto-merge (squash) April 7, 2025 10:44
@lszomoru lszomoru merged commit 0bc678a into main Apr 7, 2025
8 checks passed
@lszomoru lszomoru deleted the lszomoru/windows-codesign-revert branch April 7, 2025 11:05
lszomoru added a commit that referenced this pull request Apr 7, 2025
@lszomoru
Reapply "Engineering - background codesign for Windows stage (#245796)…
788d487 
…" (#245869)

This reverts commit 0bc678a.
lszomoru added a commit that referenced this pull request Apr 7, 2025
@lszomoru
Engineering - background codesign for Windows (#245885)
7a92a7f 
* Reapply "Engineering - background codesign for Windows stage (#245796)" (#245869)

This reverts commit 0bc678a.

* Update version calculation

* Remove code that is not needed

* Add missing javascript file

* Fix server path

* Always publish artifacts
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators May 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chrmarti chrmarti chrmarti approved these changes

Assignees

@lszomoru lszomoru

Labels

engineering VS Code - Build / issue tracking / etc.

Projects

None yet

Milestone

April 2025

Development

Successfully merging this pull request may close these issues.

3 participants

@lszomoru @chrmarti