Change window.experimentalControlOverlay's scope to application#230593
Merged
bpasero merged 1 commit intomicrosoft:mainfrom Oct 7, 2024
Merged
Change window.experimentalControlOverlay's scope to application#230593bpasero merged 1 commit intomicrosoft:mainfrom
window.experimentalControlOverlay's scope to application#230593bpasero merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
Author
|
(Manually testing)
(You guys already have a good system, i just wanted to make sure it works before wasting CI times) |
bpasero
approved these changes
Oct 5, 2024
1 task
lszomoru
approved these changes
Oct 6, 2024
songjianet
approved these changes
Oct 6, 2024
auto-merge was automatically disabled
October 6, 2024 15:42
Pull request was closed
auto-merge was automatically disabled
October 6, 2024 16:36
Pull request was closed
auto-merge was automatically disabled
October 6, 2024 21:14
Head branch was pushed to by a user without write access
kalebers
approved these changes
Oct 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #230353 by changing the scope of
window.experimentalControlOverlayto application/default profile scope to avoid the window controls being detached from the state of the window (fullscreen/windowed)