fix: add disposable to elementDisposables instead of templateDisposables in renderElement function in SettingEnumRenderer #216855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les in renderElement function in SettingEnumRenderer
rzhao271
approved these changes
Jun 24, 2024
aeschli
approved these changes
Jun 24, 2024
aaronchucarroll
pushed a commit
to aaronchucarroll/vscode
that referenced
this pull request
Jul 10, 2024
…les in renderElement function in SettingEnumRenderer (microsoft#216855)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with #216649
In SettingEnumRenderer, the
renderElementfunction calls therenderValuefunction, whichs adds disposables to the template disposables instead of the element disposables.It seems the disposables in
renderValueshould always be added toelementDisposables: