Skip to content

debt - enlist most JS files in tsconfig.json #216566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bpasero merged 5 commits into from
Jun 19, 2024
Merged

debt - enlist most JS files in tsconfig.json #216566

bpasero merged 5 commits into from
Jun 19, 2024

Conversation

@bpasero
Copy link
Member

@bpasero bpasero commented Jun 19, 2024 •
edited
Loading

cc @mjbvz

@bpasero bpasero self-assigned this Jun 19, 2024
@bpasero bpasero added this to the June 2024 milestone Jun 19, 2024
@bpasero bpasero marked this pull request as ready for review June 19, 2024 06:01
@bpasero bpasero enabled auto-merge (squash) June 19, 2024 06:01
@bpasero bpasero merged commit 83f03bb into main Jun 19, 2024
@bpasero bpasero deleted the ben/absolute-antlion branch June 19, 2024 06:35
@jakebailey
Copy link
Member

jakebailey commented Jun 20, 2024

FYI this PR causes tsc -p ./src to fall over because src/vs/workbench/contrib/webview/browser/pre/service-worker.js contains no-default-lib, which is not for use anywhere but in dts files that are trying to be lib.d.ts.

@jakebailey jakebailey mentioned this pull request Jun 20, 2024
Merged
@bpasero
Copy link
Member Author

bpasero commented Jun 21, 2024

Thanks for checking in!

bricefriha pushed a commit to bricefriha/vscode that referenced this pull request Jun 26, 2024
@bpasero @bricefriha
debt - enlist most JS files in tsconfig.json (microsoft#216566)
e8f6f84
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jrieken jrieken jrieken approved these changes

Assignees

@bpasero bpasero

Labels

None yet

Projects

None yet

Milestone

June 2024

Development

Successfully merging this pull request may close these issues.

4 participants

@bpasero @jakebailey @jrieken