Revert "Tunnel: Extend port mapping lookup also for querystring (#203908)"#205370
Merged
Revert "Tunnel: Extend port mapping lookup also for querystring (#203908)"#205370
Conversation
)" This reverts commit 08eda83.
chrmarti
approved these changes
Feb 16, 2024
orgads
added a commit
to orgads/vscode
that referenced
this pull request
Feb 18, 2024
When running az login, the URL has localhost in redirect_uri query param. This should trigger automatic port mapping. Improve localhost port mapping to cover this case as well. This is a revised and tested version of microsoft#203908 which was reverted in microsoft#205370. Fixes microsoft#203869
orgads
added a commit
to orgads/vscode
that referenced
this pull request
Mar 1, 2024
When running az login, the URL has localhost in redirect_uri query param. This should trigger automatic port mapping. Improve localhost port mapping to cover this case as well. This is a revised and tested version of microsoft#203908 which was reverted in microsoft#205370. Fixes microsoft#203869
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 08eda83.