Add support for recognizing word locales in word operations (#50045)#203605
Merged
alexdima merged 7 commits intomicrosoft:mainfrom Mar 15, 2024
Merged
Add support for recognizing word locales in word operations (#50045)#203605alexdima merged 7 commits intomicrosoft:mainfrom
alexdima merged 7 commits intomicrosoft:mainfrom
Conversation
|
In addition to word boundary inside Japanese/Chinese sentences, I think boundary between Japanese/Chinese character and Latin character should be considered as word boundary by default. Like: |
Member
|
@alexdima this is a very interesting improvement, assigning to you since you added the grapheme clusters support. let me know if you need anything from my side. |
alexdima
approved these changes
Mar 15, 2024
Member
|
Thank you! |
bpasero
approved these changes
Mar 15, 2024
chen-ky
pushed a commit
to chen-ky/vscode
that referenced
this pull request
Mar 18, 2024
…t#50045) (microsoft#203605) * Add support for recognizing word locales in word operations (microsoft#50045) * Move intlSegmenterLocales in the WordCharacterClassifier class * Rerun compiler * Renames * Avoid duplicating code --------- Co-authored-by: Alex Dima <alexdima@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponds to #50045 in Feature request.
This feature allows you to use
Ctrl+LeftorCtrl+Rightto navigate in languages that are not separated by spaces, such as Japanese or Chinese, with word separators.If the user does not enter any settings, the system will continue to operate as before, so English speakers and others who do not need this feature will not be affected.
Since I am Japanese and often write Markdown and other Japanese text in VS Code, this feature was needed and desired by many people around me.
Example now: (use
|as the cursor)or if the setting is
"editor.recognizeWordLocales": ""(default).Example of functionality enabled
The setting is
"editor.recognizeWordLocales": "ja".