# Add partial accept kind to inline completion handle#202668
# Add partial accept kind to inline completion handle#202668hediet merged 28 commits intomicrosoft:mainfrom
Conversation
|
Sorry for the early ping, I tried to keep the PR in draftmode but you already got assigned. The issues should be resolved now :) |
|
Reworked the API (original proposed changes), to allow easy onboarding of new users (wouldn't cause breakage when released with extensions). |
|
Hey @bhavyaus , Is there any additional changes that you would like me to add to the PR? Also if I may be so bold to ask, why did you add the |
Apologies. I was performing endgame testing. Ignore my previous comment.
@justschen , could you please help take a look. |
# Conflicts: # src/vs/editor/contrib/inlineCompletions/browser/inlineCompletionsModel.ts # src/vs/editor/standalone/browser/standaloneLanguages.ts # src/vs/workbench/api/common/extHost.api.impl.ts # src/vs/workbench/api/common/extHostTypeConverters.ts
3632bec to
516cb6a
Compare
* # Add partial accept kind to inline completion handle --------- Co-authored-by: Henning Dieterichs <hdieterichs@microsoft.com>
1st part of the partial accept handler enrichment
This first proposal enables the metadata to be attached in the core to the partialAcceptHandler to return the
Kindof partial acceptance that was triggered.This allows for deeper understanding of user interactions, as well as filtering out specific triggers when doing post analysis (e.g. Suggest).
#195369