Merge x-doc and occurrence setting, merge word based suggestion settings #197690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebornix
reviewed
Nov 8, 2023
suggestions and occurrence highlighting + settings migration
rebornix
approved these changes
Nov 10, 2023
Contributor
|
@Yoyokrazy This PR breaks our extension's default settings -- what is the recommended way for us to handle this? There doesn't appear to be any migration or compatibility in place for settings values set by extensions. I have PR at https://github.com/microsoft/vscode-cpptools/pull/11773/files that fixes it for 1.85.0, but that would regress old VS Code versions unless we increased our minimum supported VS Code version (causing users with 1.84.0 to not see our updates). i.e. it appears that user settings have a migration/conversion in place, which isn't being run on the extension's "configurationDefaults" in package.json I created a bug report at #200685 . |
hrishikesh-kadam
added a commit
to hrishikesh-kadam/dart-flutter-vscode-extension
that referenced
this pull request
Dec 13, 2023
hrishikesh-kadam
added a commit
to hrishikesh-kadam/dart-flutter-vscode-extension-website
that referenced
this pull request
Dec 13, 2023
DanTup
pushed a commit
to Dart-Code/Website
that referenced
this pull request
Dec 13, 2023
DanTup
pushed a commit
to Dart-Code/Dart-Code
that referenced
this pull request
Dec 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #196353
This mirrors the approach of word based suggestions and the associated settings there. No behavior changes at all with this, just much improved readability and the behavior more closely aligns with the setting descriptions/names.
Can also tweak and merge the settings into a single setting with multiple accepted value sets (ie boolean | enum), though to some effect I think that may reduce discoverability.