-
Notifications
You must be signed in to change notification settings - Fork 37.4k
fix: bracket pair fails in nested template string(#190564) #195557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This also does not fix it, as it would highlight brackets in |
Got it. Probably other selector expression can make it. |
|
@hediet I can't reproduce your case, I get the following result which bracket not highlight. |
|
Ah, this one only marks quoted strings as strings. Template strings are not marked as strings. I fear this causes other problems, e.g. for the bracket auto-closing. |
|
I see. I can't ensure other problems either as my poor understanding of the codebase. |
|
The expression enclosed by So I think we can remove all these: vscode/extensions/javascript/package.json Lines 91 to 93 in f9d4ac5
This leaves one problem. "punctuation.definition.template-expression": "other",I'm not very familiar with JavaScript, I'm actually working on https://github.com/bmalehorn/vscode-fish, so I'm not totally sure this will work. |


Fix #190564
In
extensions/typescript-basics/syntaxes/TypeScript.tmLanguage.json, The selectors which start with "string" are "string.quoted", "string.regexp" and "string.template", in fact we should only treat "string.quoted" as string. Please check!