Reset token type of meta.embedded scopes #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft/vscode#34857 See microsoft/vscode#34857 for more details about this issue
mjbvz
commented
Sep 22, 2017
src/main.ts
Outdated
| String = 2, | ||
| RegEx = 4 | ||
| RegEx = 4, | ||
| MetaEmbedded = 8 |
Contributor
Author
There was a problem hiding this comment.
No encoded tokens will ever be marked as MetaEmbeded. It's just used internally to reset the scope. Let me know if you can think of a better way to express this
Member
There was a problem hiding this comment.
Yes, this is problematic because this enum makes it in the public module API
Contributor
Author
|
Hey @alexandrudima, can you please take a look at this PR and let me know if you have any feedback or alternate design suggestions |
Contributor
Author
|
Ping @alexandrudima. I'd really like to see if we can address microsoft/vscode#34857 for October |
Contributor
Author
|
The changes to use the internal enum type look good to me. Thanks for looking into this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode#34857
See microsoft/vscode#34857 for more details about this issue