Merged
Conversation
Tyriar
approved these changes
Sep 25, 2023
lins0621
pushed a commit
to lins0621/vscode
that referenced
this pull request
Oct 7, 2023
Align with explorer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #193574
The UX is still not perfect here, as I feel if you explicilty click the X button it should close that entry, but instead it executes
closeActiveEditor. This more closely aligns with what we do in the explorer at least so they're the same (except the explorer doesn't have an explicit button). If a selection is of length 1 we prefer focus, otherwise we're in a multi select context and should prefer the selection.