Use indentSize instead of tabSize for LineCommentCommand#193811
Merged
alexdima merged 4 commits intomicrosoft:mainfrom Mar 16, 2024
Merged
Use indentSize instead of tabSize for LineCommentCommand#193811alexdima merged 4 commits intomicrosoft:mainfrom
alexdima merged 4 commits intomicrosoft:mainfrom
Conversation
Tab size and indent size were separated in microsoft#155450, but for deciding where to put "//" or "#" when toggling a line comment tab size was still used. Fixes microsoft#170393.
a71e408 to
de422ea
Compare
Contributor
Author
|
Any comments? I know this probably only affects a small percentage of users (mostly those who have to use legacy code bases which used the tab character incorrectly), but the change should be easy to reason about as |
Tyriar
approved these changes
Mar 16, 2024
chen-ky
pushed a commit
to chen-ky/vscode
that referenced
this pull request
Mar 18, 2024
…93811) Tab size and indent size were separated in microsoft#155450, but for deciding where to put "//" or "#" when toggling a line comment tab size was still used. Fixes microsoft#170393. Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tab size and indent size were separated in #155450, but for deciding where to put "//" or "#" when toggling a line comment tab size was still used.
Fixes #170393.