fix: allow underscore as a valid char in tunnel remote address#190904
Merged
alexr00 merged 1 commit intomicrosoft:mainfrom Aug 21, 2023
Merged
fix: allow underscore as a valid char in tunnel remote address#190904alexr00 merged 1 commit intomicrosoft:mainfrom
alexr00 merged 1 commit intomicrosoft:mainfrom
Conversation
…rscore as a valid char.
eee19ce to
ddc1d2a
Compare
joyceerhl
approved these changes
Aug 21, 2023
Krzysztof-Cieslak
pushed a commit
to githubnext/vscode
that referenced
this pull request
Sep 18, 2023
…soft#190904) adjust the regexes used to validate tunnel remote addresses, add underscore as a valid char.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #190902
The linked issue pretty much explains the problem.
Although I was able to test the UI validation change, the schema.json was kind of a guess. It looked related but I don't know its exact purpose.
Also, I don't know whether this will now fail at a later point. Maybe there was a reason why this was disallowed until now.
I have not quite figured out how to build my local vscode fork (inside a devcontainer) to a fully usable app to replace my normal installation with.