Polish dim unfocused settings and remove element when not used#190751
Merged
Polish dim unfocused settings and remove element when not used#190751
Conversation
meganrogge
approved these changes
Aug 18, 2023
Contributor
|
@Tyriar not sure if I'm missing something but the old setting worked a few weeks ago but now that I try the new settings (and the old setting) with the latest insider it doesn't get recognized and I don't get any dim editors/terminals any longer. I can't find it in the settings UI either.
|
Contributor
|
Aha, I found it in the "Remote WSL" settings, but it is not available in the "User" settings, not sure if this is intended behavior or a bug? |
Member
Author
|
@SvanT thanks, that is a bug. No need for another issue, I'll fix it now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to the discussion at #30522 (comment). The
accessibility.unfocusedViewOpacitysetting has been split intoworkbench.view.dimUnfocused.enabledandworkbench.view.dimUnfocused.opacity. They remain implemented in the accessibility contrib and still include the accessibility tag so they can be accessed via@tag:accessibility.The element is also removed when the enabled setting is false.
Fixes #30522