Conversation
src/vs/workbench/contrib/accessibility/browser/accessibilityContribution.ts
Show resolved
Hide resolved
|
Looks a little funny with this set to 0 - should there be a min value? Maybe some people would want this?
|
|
Disallowing 0 is a good idea as it looks broken, I'll make the min 0.1 or 0.2 |
daviddossett
left a comment
There was a problem hiding this comment.
Tried it locally and it feels good 👍
The opacity percentage (0.0 to 1.0)
This feels somewhat misleading since it isn't 0-100 like a traditional %. I know we're mapping this to how CSS opacity is set but I wonder if either rewording this or using a 0-100 scale would be clearer.
|
@daviddossett I'd guess we use 0-1 to represent a percentage more than 0-100 already, looking through my settings I see |
|
failure @Tyriar maybe rerun? |
|
Really excited for this! I can't tell you how often I end up typing 'git' into random spots in my files, thinking I'm typing in the terminal. Any chance this part could be dimmed, too, so it's the entire terminal pane? |
|
@lobsterkatie great to hear, yes fading the tabs makes sense. I'll try get to that today. Please keep the feedback coming. |
Fixes #30522
Still pending internal discussion...