Skip to content

support explorer.copyPathSeparator#184884

Merged
lramos15 merged 4 commits intomicrosoft:mainfrom
liudonghua123:feature_copy_path_separator
Mar 21, 2025
Merged

support explorer.copyPathSeparator#184884
lramos15 merged 4 commits intomicrosoft:mainfrom
liudonghua123:feature_copy_path_separator

Conversation

@liudonghua123
Copy link
Contributor

Hi, I tried to add a configuration to support copy path separator customization. And I have tested, it worked as expected.

3400cd2407c66c4c0febc10bf3bdec6

@liudonghua123
Copy link
Contributor Author

@microsoft-github-policy-service agree

@liudonghua123
Copy link
Contributor Author

@lramos15 @jrieken @joaomoreno Hi, could you take some time to review my first pr, I saw Community PR Approvals action need at least three approvals. I hope the feature could merged into the upstream branch as soon as possible.

Thanks in advanced.

If there anything I missed or can be improved, tell me and I'll fix it.

@liudonghua123 liudonghua123 force-pushed the feature_copy_path_separator branch from 9d10061 to 59478c1 Compare June 12, 2023 14:44
@kiraacorsac
Copy link

I hope this will get merged, it would be very useful for me.

Copy link

@conorpo conorpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable names could maybe change, but this PR seems like a net positive.

@liudonghua123
Copy link
Contributor Author

liudonghua123 commented Feb 5, 2024

Variable names could maybe change, but this PR seems like a net positive.

Hi, is there anything I can do about this pr, just let me know. 😀

@AgainPsychoX
Copy link

AgainPsychoX commented Jun 17, 2024

Bump

@jwittner
Copy link
Member

jwittner commented Mar 18, 2025

How can we get traction on this feature? We need to somehow find 1 more reviewer?

@jwittner
Copy link
Member

jwittner commented Mar 20, 2025

In the Pull Request section of the contributing doc it asks to link the PR to an issue. I think you mention this PR in #164153, but if you put, Resolves #164153 in the PR description it might raise the awareness of the link and will auto-close that issue when this merges?

@vs-code-engineering vs-code-engineering bot added this to the March 2025 milestone Mar 21, 2025
@lramos15 lramos15 enabled auto-merge (squash) March 21, 2025 15:31
@Tyriar
Copy link
Member

Tyriar commented Mar 21, 2025

@lramos15 why do we need this? Isn't there always a correct way to do it?

@Tyriar Tyriar disabled auto-merge March 21, 2025 16:59
@lramos15 lramos15 merged commit 0bd25fc into microsoft:main Mar 21, 2025
11 checks passed
@jwittner
Copy link
Member

Yay! Thanks for coming back to this PR and reviewing. This will improve my workflows using copy path dramatically!

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators May 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants